Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added govulncheck to backplane-cli CI #42707

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Added govulncheck to backplane-cli CI #42707

merged 2 commits into from
Sep 5, 2023

Conversation

Dee-6777
Copy link
Contributor

@Dee-6777 Dee-6777 commented Aug 26, 2023 •
edited
Loading

This PR is for the issue OSD-18227 to add govulncheck in backplane-cli CI check.

@Dee-6777
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2023
@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: could not set regex: for job pull-ci-openshift-backplane-cli-main-test, rerun command "/test govulncheck" does not match trigger "(?m)^/test( | .* )test,?($|\s.*)"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Dee-6777
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@Dee-6777
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: could not set regex: for job pull-ci-openshift-backplane-cli-main-test, rerun command "/test scan" does not match trigger "(?m)^/test( | .* )test,?($|\s.*)"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Dee-6777 Dee-6777 force-pushed the add-govulncheck-to-bpcli-ci branch 2 times, most recently from 4ae641f to 75689a3 Compare August 31, 2023 06:14
@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: could not set regex: for job pull-ci-openshift-backplane-cli-main-test, rerun command "/test scan" does not match trigger "(?m)^/test( | .* )test,?($|\s.*)"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: could not set regex: for job pull-ci-openshift-backplane-cli-main-test, rerun command "/test scan" does not match trigger "(?m)^/test( | .* )test,?($|\s.*)"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: duplicated presubmit job: pull-ci-openshift-backplane-cli-main-test
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@Dee-6777, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: duplicated presubmit job: pull-ci-openshift-backplane-cli-main-test
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Dee-6777
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-backplane-cli-main-scan

@Dee-6777 Dee-6777 force-pushed the add-govulncheck-to-bpcli-ci branch 2 times, most recently from c998af9 to ebf6af7 Compare August 31, 2023 10:24
supreeth7
supreeth7 suggested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@supreeth7 supreeth7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is missing the job configuration.
You will need to run make jobs to generate Prow job configuration files out of ci-operator configuration files.

Suggestion: Try running make jobs WHAT=openshift/backplane-cli from the root of the repository to fix the issue.

@Dee-6777 Dee-6777 changed the title Added govulncheck to backplane CI Added govulncheck to backplane-cli CI Sep 1, 2023
@supreeth7
Copy link
Contributor

/pj-rehearse
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 4, 2023
@supreeth7
Copy link
Contributor

/retest

@supreeth7
Copy link
Contributor

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@supreeth7, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag openshift/release:golang-1.20 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Dee-6777: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-backplane-cli-main-scan openshift/backplane-cli presubmit Presubmit changed
pull-ci-openshift-backplane-cli-main-build openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-coverage openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-images openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-lint openshift/backplane-cli presubmit Ci-operator config changed
pull-ci-openshift-backplane-cli-main-test openshift/backplane-cli presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@supreeth7
Copy link
Contributor

/pj-rehearse auto-ack

@Dee-6777
Copy link
Contributor Author

Dee-6777 commented Sep 5, 2023 •
edited
Loading

@supreeth7 I think the version of CI and the go version in bp-cli should be the same to fix this error. Because go version in go.mod for bpcli is 1.21 and all test cases passed when I made CI version to 1.21

@supreeth7
Copy link
Contributor

@Dee-6777 The rehearsals didn't pass back then as go1.21 image tag doesn't exist in the release/openshift registry.
The make scan is expected to fail as every release of go will have vulnerabilities that will be fixed in the next release, but we cannot keep bumping our base image to the latest go version and expect it to be a support base image in the OCP image registry.

I'd like to make the control over our CI easier, I'll address it in a couple of PRs soon.

supreeth7
supreeth7 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@supreeth7 supreeth7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/pj-rehearse ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dee-6777, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@supreeth7
Copy link
Contributor

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2023
@supreeth7
Copy link
Contributor

/retest

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

@Dee-6777: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/backplane-cli/main/govulncheck ae1be63d09b737be449702af9bf4fb3035966415 link unknown /pj-rehearse pull-ci-openshift-backplane-cli-main-scan
ci/rehearse/openshift/backplane-cli/main/lint 9a314df link unknown /pj-rehearse pull-ci-openshift-backplane-cli-main-lint
ci/rehearse/openshift/backplane-cli/main/scan 9a314df link unknown /pj-rehearse pull-ci-openshift-backplane-cli-main-scan

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7f6074e into openshift:master Sep 5, 2023
prb112 pushed a commit to prb112/openshift-release that referenced this pull request Sep 12, 2023
@Dee-6777 @prb112
Added govulncheck to backplane-cli CI (openshift#42707)
0ab2f30 
* update go-version of CI to 1.20

* update go-version of CI to 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanthajayasinghe samanthajayasinghe samanthajayasinghe left review comments

@supreeth7 supreeth7 supreeth7 approved these changes

@hectorakemp hectorakemp Awaiting requested review from hectorakemp

@Tafhim Tafhim Awaiting requested review from Tafhim

Assignees

@supreeth7 supreeth7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dee-6777 @openshift-ci-robot @supreeth7 @samanthajayasinghe @openshift-merge-robot